Skip to content

Conversation

@YuvalFilmus
Copy link
Collaborator

@YuvalFilmus YuvalFilmus commented Jan 16, 2026

RootsExtrema fulfills one TODO and is the appropriate place for another.


(Perhaps it is also the appropriate place for formulas involving square roots?)

Open in Gitpod

@YuvalFilmus YuvalFilmus added the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 16, 2026
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

PR summary 9b524ac2e0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg changed the title doc(Chebyshev): Update TODO doc(Chebyshev): update TODO Jan 16, 2026
@grunweg
Copy link
Collaborator

grunweg commented Jan 16, 2026

Thank you!
bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 16, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2026
RootsExtrema fulfills one TODO and is the appropriate place for another.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Build failed (retrying...):

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 16, 2026
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Canceled.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 16, 2026
@grunweg
Copy link
Collaborator

grunweg commented Jan 16, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2026
RootsExtrema fulfills one TODO and is the appropriate place for another.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(Chebyshev): update TODO [Merged by Bors] - doc(Chebyshev): update TODO Jan 16, 2026
@mathlib-bors mathlib-bors bot closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants